Flatten sei-ibc-go module into sei-chain#2611
Conversation
Remove another unnecessary nesting of go.mod for sei-ibc-go
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (43.87%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
==========================================
- Coverage 43.22% 43.21% -0.02%
==========================================
Files 1857 1857
Lines 153124 153168 +44
==========================================
- Hits 66190 66189 -1
- Misses 81013 81046 +33
- Partials 5921 5933 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| bz := k.MustMarshalConsensusState(upgradedConsState) | ||
|
|
||
| k.SetUpgradedConsensusState(ctx, plan.Height, bz) | ||
| if err := k.SetUpgradedConsensusState(ctx, plan.Height, bz); err != nil { |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
There was a problem hiding this comment.
already contains a panic at line 42.
|
|
||
| k.SetUpgradedConsensusState(ctx, plan.Height, bz) | ||
| if err := k.SetUpgradedConsensusState(ctx, plan.Height, bz); err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
|
|
||
| k.SetUpgradedConsensusState(ctx, plan.Height, bz) | ||
| if err := k.SetUpgradedConsensusState(ctx, plan.Height, bz); err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| return NewHeight(revision, uint64(ctx.BlockHeight())) | ||
| blockHeight := ctx.BlockHeight() | ||
| if blockHeight < 0 { | ||
| panic("block height is negative") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| setConsensusMetadataWithValues(clientStore, height, clienttypes.GetSelfHeight(ctx), uint64(ctx.BlockTime().UnixNano())) | ||
| blockTimeNano := ctx.BlockTime().UnixNano() | ||
| if blockTimeNano < 0 { | ||
| panic("block time is negative") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| import ( | |||
| "bytes" | |||
| "math" | |||
Check notice
Code scanning / CodeQL
Sensitive package import Note
4 participants
Remove another unnecessary nesting of go.mod for sei-ibc-go
Fix various bugs, lint and security issues.