Skip to content

migrated ed25519 primitives from sei-v3#2618

Merged
pompon0 merged 52 commits intomainfrom
gprusak-validator-proto
Dec 22, 2025
Merged

migrated ed25519 primitives from sei-v3#2618
pompon0 merged 52 commits intomainfrom
gprusak-validator-proto

Conversation

@pompon0
Copy link
Copy Markdown
Contributor

@pompon0 pompon0 commented Dec 16, 2025

Copy-pasted ed25519 primitives from sei-v3 (they underlying ed25519 library is the same) and adjusted the codebase accordingly. Since we are migrating to autobahn, the changes below prefer the sei-v3 codebase conventions (lmk if you have concerns).
In particular:

  • signatures are wrapped in a type now: ed25519.Signature
  • PrivateKey renamed to SecretKey (and SecretKey.PubKey() to SecretKey.Public())
  • added best-effort zeroize for SecretKey, copy-prevention and printing-prevention
  • Vote and CommitSig now include Option[Signature], because they occur both in signed and unsigned states for some reason.
  • all hashes, signatures, proto, json encodings stay backward compatible
  • added change-detector test for json encodings of crypto types
  • removed typeRegistry from sei-tendermin/libs/json, because it is effectively unused (only PublicKey was registered AND it was not effective, because everywhere the PublicKey was encoded, it was actually using a custom json marshaler).
  • removed sei-cosmos/server/in_plage.go command, because it seems to be stale (lmk if it is actually needed)

"fmt"
"io"
"bytes"
"runtime"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
@pompon0 pompon0 changed the title Gprusak validator proto migrated ed25519 impl from sei-v3 Dec 18, 2025
@pompon0 pompon0 marked this pull request as ready for review December 18, 2025 12:43
@pompon0 pompon0 changed the title migrated ed25519 impl from sei-v3 migrated ed25519 primitives from sei-v3 Dec 18, 2025
@pompon0 pompon0 enabled auto-merge (squash) December 22, 2025 14:59
@pompon0 pompon0 merged commit cfa7ea6 into main Dec 22, 2025
38 of 39 checks passed
@pompon0 pompon0 deleted the gprusak-validator-proto branch December 22, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants