Skip to content

[CON-152] fix: state: safely set per-account maps when handling reverts#2626

Merged
arajasek merged 1 commit intomainfrom
asr/fix-journal
Dec 17, 2025
Merged

[CON-152] fix: state: safely set per-account maps when handling reverts#2626
arajasek merged 1 commit intomainfrom
asr/fix-journal

Conversation

@arajasek
Copy link
Copy Markdown
Contributor

@arajasek arajasek commented Dec 17, 2025

Describe your changes and provide context

Fixes an edge-case where two reverts could be unsafe.

Testing performed to validate your change

Added a new test

@arajasek arajasek changed the title fix: state: safely set per-account maps when handling reverts [CON-152] fix: state: safely set per-account maps when handling reverts Dec 17, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 17, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 17, 2025, 7:07 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.62%. Comparing base (f07bc96) to head (a3d6fc0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/evm/state/journal.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2626   +/-   ##
=======================================
  Coverage   43.61%   43.62%           
=======================================
  Files        1899     1899           
  Lines      158396   158401    +5     
=======================================
+ Hits        69087    69102   +15     
+ Misses      82966    82957    -9     
+ Partials     6343     6342    -1     
Flag Coverage Δ
sei-chain 45.53% <60.00%> (+0.01%) ⬆️
sei-cosmos 38.03% <ø> (+<0.01%) ⬆️
sei-db 69.06% <ø> (ø)
sei-tendermint 47.51% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
x/evm/state/journal.go 85.71% <60.00%> (-3.48%) ⬇️

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

arajasek added a commit that referenced this pull request Dec 17, 2025
## Describe your changes and provide context

Similar to #2626, we should handle potential duplicates safely in access
list changes.

## Testing performed to validate your change

Added a new test.
@arajasek arajasek enabled auto-merge (squash) December 17, 2025 19:07
@arajasek arajasek merged commit def3050 into main Dec 17, 2025
41 of 42 checks passed
@arajasek arajasek deleted the asr/fix-journal branch December 17, 2025 20:10
arajasek added a commit that referenced this pull request Jan 29, 2026
arajasek added a commit that referenced this pull request Jan 30, 2026
arajasek added a commit that referenced this pull request Jan 30, 2026
arajasek added a commit that referenced this pull request Feb 2, 2026
arajasek added a commit that referenced this pull request Feb 4, 2026
arajasek added a commit that referenced this pull request Feb 5, 2026
arajasek added a commit that referenced this pull request Feb 6, 2026
arajasek added a commit that referenced this pull request Feb 10, 2026
arajasek added a commit that referenced this pull request Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants