Skip to content

Backport release/v6.3: Log the panic callstack for debugging purposes #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masih merged 1 commit into from
Dec 18, 2025
Merged

Backport release/v6.3: Log the panic callstack for debugging purposes #2633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"os"
"path/filepath"
"regexp"
"runtime/debug"
"strings"
"sync"
"time"
Expand Down Expand Up @@ -1399,12 +1400,14 @@ func (app *App) ProcessBlock(ctx sdk.Context, txs [][]byte, req BlockProcessRequ
defer func() {
if r := recover(); r != nil {
panicMsg := fmt.Sprintf("%v", r)

// Re-panic for upgrade-related panics to allow proper upgrade mechanism
if upgradePanicRe.MatchString(panicMsg) {
ctx.Logger().Error("upgrade panic detected, panicking to trigger upgrade", "panic", r)
panic(r) // Re-panic to trigger upgrade mechanism
}
ctx.Logger().Error("panic recovered in ProcessBlock", "panic", r)
stack := string(debug.Stack())
ctx.Logger().Error("panic recovered in ProcessBlock", "panic", r, "stack", stack)
err = fmt.Errorf("ProcessBlock panic: %v", r)
events = nil
txResults = nil
Expand Down