Skip to content

[CON-154] fix: test: ensure own precommit before adding votes#2635

Merged
philipsu522 merged 2 commits intomainfrom
asr/fix-pbts-test
Dec 23, 2025
Merged

[CON-154] fix: test: ensure own precommit before adding votes#2635
philipsu522 merged 2 commits intomainfrom
asr/fix-pbts-test

Conversation

@arajasek
Copy link
Copy Markdown
Contributor

This test can flake (eg here), and I'm pretty sure it's because the network moves onto the next height before we've ensured our own precommit. Switching the order of operations should prevent this.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 19, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 23, 2025, 6:52 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.97%. Comparing base (ffc83e6) to head (7d49cb1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2635      +/-   ##
==========================================
+ Coverage   41.95%   41.97%   +0.01%     
==========================================
  Files        1018     1018              
  Lines       84809    84809              
==========================================
+ Hits        35583    35595      +12     
+ Misses      45878    45862      -16     
- Partials     3348     3352       +4     
Flag Coverage Δ
sei-cosmos 38.20% <ø> (ø)
sei-db 69.06% <ø> (ø)
sei-tendermint 47.23% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philipsu522 philipsu522 merged commit 9109a8a into main Dec 23, 2025
38 of 39 checks passed
@philipsu522 philipsu522 deleted the asr/fix-pbts-test branch December 23, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants