[CON-154] fix: test: ensure own precommit before adding votes#2635
Merged
philipsu522 merged 2 commits intomainfrom Dec 23, 2025
Merged
[CON-154] fix: test: ensure own precommit before adding votes#2635philipsu522 merged 2 commits intomainfrom
philipsu522 merged 2 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
b7dbd72 to
fe0f409
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2635 +/- ##
==========================================
+ Coverage 41.95% 41.97% +0.01%
==========================================
Files 1018 1018
Lines 84809 84809
==========================================
+ Hits 35583 35595 +12
+ Misses 45878 45862 -16
- Partials 3348 3352 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
fe0f409 to
716c6d5
Compare
philipsu522
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test can flake (eg here), and I'm pretty sure it's because the network moves onto the next height before we've ensured our own precommit. Switching the order of operations should prevent this.