feat: mempool: don't add pending txs to priority reservoir#2641
Merged
feat: mempool: don't add pending txs to priority reservoir#2641
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
==========================================
- Coverage 46.38% 43.79% -2.60%
==========================================
Files 1237 1904 +667
Lines 108362 158932 +50570
==========================================
+ Hits 50265 69604 +19339
- Misses 53489 82931 +29442
- Partials 4608 6397 +1789
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| func (txmp *TxMempool) utilisation() float64 { | ||
| return float64(txmp.Size()) / float64(txmp.config.Size) | ||
| return float64(txmp.NumTxsNotPending()) / float64(txmp.config.Size) |
Check notice
Code scanning / CodeQL
Floating point arithmetic Note
arajasek
force-pushed
the
asr/fix-mempool-spam
branch
from
38b3891 to
f196006
Compare
sei-will
approved these changes
Jan 5, 2026
arajasek
force-pushed
the
asr/fix-mempool-spam
branch
from
f196006 to
2f6c13d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't know whether pending txs will actually ever land, so they can throw off our metrics for utilization and priority reservoir.