Skip to content

[CON-151] fix: test: replace flaky Sleep with more predictable wait#2642

Merged
philipsu522 merged 1 commit intomainfrom
asr/fix-async-test
Dec 23, 2025
Merged

[CON-151] fix: test: replace flaky Sleep with more predictable wait#2642
philipsu522 merged 1 commit intomainfrom
asr/fix-async-test

Conversation

@arajasek
Copy link
Copy Markdown
Contributor

As in the title, this should prevent this test from flaking (or at least decrease the likelihood).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 22, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 22, 2025, 9:26 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.00%. Comparing base (cfa7ea6) to head (ecc7519).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2642      +/-   ##
==========================================
- Coverage   43.71%   42.00%   -1.72%     
==========================================
  Files        1902     1018     -884     
  Lines      158677    84807   -73870     
==========================================
- Hits        69373    35624   -33749     
+ Misses      82914    45841   -37073     
+ Partials     6390     3342    -3048     
Flag Coverage Δ
sei-chain ?
sei-cosmos 38.20% <ø> (ø)
sei-db 69.06% <ø> (ø)
sei-tendermint 47.32% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 895 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arajasek arajasek changed the title fix: test: replace flaky Sleep with more predictable wait [CON-151] fix: test: replace flaky Sleep with more predictable wait Dec 23, 2025
@philipsu522 philipsu522 merged commit 3078fb2 into main Dec 23, 2025
41 of 43 checks passed
@philipsu522 philipsu522 deleted the asr/fix-async-test branch December 23, 2025 15:44
blindchaser pushed a commit that referenced this pull request Jan 2, 2026
#2642 accidentally copy-pasted and extra assertion, this fixes that up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants