Merged
Conversation
This reverts commit 7aacf5b.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
==========================================
- Coverage 43.81% 43.81% -0.01%
==========================================
Files 1907 1906 -1
Lines 158902 158877 -25
==========================================
- Hits 69623 69612 -11
+ Misses 82881 82869 -12
+ Partials 6398 6396 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| if counter == math.MaxUint64 { | ||
| // Terminates the session and makes sure the nonce would not re-used. | ||
| // See https://github.com/tendermint/tendermint/issues/3531 | ||
| panic("can't increase nonce without overflow") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| return n, err | ||
| } | ||
| return n, err | ||
| panic("unreachable") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
sei-will
approved these changes
Jan 6, 2026
codchen
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored secret connection implementation, preparing it to multiplex between v2 and giga connections during handshake. In particular the handshake is now context aware. Additional changes: