feat: mempool: return all EVM txs before others when reaping#2669
Merged
feat: mempool: return all EVM txs before others when reaping#2669
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
arajasek
commented
Jan 6, 2026
| return append(evmTxs, nonEvmTxs...) | ||
| } | ||
|
|
||
| // ReapMaxTxs returns a list of transactions within the provided number of |
Contributor
Author
There was a problem hiding this comment.
Note the ReapMaxTxs method's behaviour is not changed by this PR, since that method is used for RPC etc. support (and not for block creation).
97bebe8 to
a899316
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2669 +/- ##
==========================================
- Coverage 46.43% 43.80% -2.64%
==========================================
Files 1241 1908 +667
Lines 108500 159079 +50579
==========================================
+ Hits 50386 69679 +19293
- Misses 53503 82990 +29487
- Partials 4611 6410 +1799
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
codchen
approved these changes
Jan 7, 2026
sei-will
approved these changes
Jan 7, 2026
a899316 to
b791d79
Compare
b791d79 to
1b5d5a2
Compare
stevenlanders
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
As a result, validators using this mempool logic will produce blocks with a batch of EVM txs, followed by any non-EVM txs. This will allow us to use future executors that can only run EVM txs to run a bigger batch of EVM txs, falling back to existing executors for all non-EVM and interop behaviour.
Note that:
Testing performed to validate your change
Added a new test, all tests pass