Skip to content

Fix rollback failure due to snapshot creation happened after app hash #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yzang2019 merged 3 commits into from
Jan 9, 2026
Merged

Fix rollback failure due to snapshot creation happened after app hash #2680

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3083e20
Only take new snapshot on snapshot interval heights
yzang2019 Jan 8, 2026
7aa7c0e
Fix comments
yzang2019 Jan 8, 2026
5160602
Merge branch 'main' into yzang/rollback-failure
yzang2019 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sei-db/state_db/sc/memiavl/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,10 +717,11 @@ func (db *DB) rewriteIfApplicable(height int64) {
snapshotVersion := db.SnapshotVersion()
blocksSinceLastSnapshot := height - snapshotVersion

// Create snapshot when both conditions are met:
// Create snapshot when all conditions are met:
// 1. Block height interval is reached (height - last snapshot >= interval)
// 2. Minimum time interval has elapsed (prevents excessive snapshots during catch-up)
if blocksSinceLastSnapshot >= int64(db.snapshotInterval) {
// 3. Block height % snapshot interval == 0
if blocksSinceLastSnapshot >= int64(db.snapshotInterval) && height%int64(db.snapshotInterval) == 0 {
timeSinceLastSnapshot := time.Since(db.lastSnapshotTime)

if timeSinceLastSnapshot < db.snapshotMinTimeInterval {
Expand Down
Loading