[CON-176] fix: test: don't run TestEventsTestSuite in parallel#2684
Merged
[CON-176] fix: test: don't run TestEventsTestSuite in parallel#2684
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2684 +/- ##
=======================================
Coverage 43.81% 43.81%
=======================================
Files 1906 1906
Lines 158877 158877
=======================================
+ Hits 69610 69615 +5
+ Misses 82879 82869 -10
- Partials 6388 6393 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
stevenlanders
approved these changes
Jan 9, 2026
yzang2019
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test can fail flakily (eg here) due to racy contention with
TestCoinTestSuite(and maybe others). Note that the contention isn't lock-related, it's that the tests clobber the global value itself.I think requiring this test to be run serially is probably the best solution.