Skip to content

fix double refund#2692

Merged
jewei1997 merged 11 commits intomainfrom
fix-double-refund
Jan 12, 2026
Merged

fix double refund#2692
jewei1997 merged 11 commits intomainfrom
fix-double-refund

Conversation

@jewei1997
Copy link
Copy Markdown
Contributor

Describe your changes and provide context

Testing performed to validate your change

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 12, 2026, 7:48 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.80%. Comparing base (cbd47b3) to head (ec84e2d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
- Coverage   43.81%   43.80%   -0.01%     
==========================================
  Files        1906     1906              
  Lines      158869   158869              
==========================================
- Hits        69607    69599       -8     
- Misses      82864    82872       +8     
  Partials     6398     6398              
Flag Coverage Δ
sei-chain 45.87% <ø> (-0.02%) ⬇️
sei-cosmos 38.20% <ø> (ø)
sei-db 69.43% <ø> (ø)
sei-tendermint 47.30% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jewei1997 jewei1997 merged commit f72a9f3 into main Jan 12, 2026
39 checks passed
@github-actions
Copy link
Copy Markdown

Backport failed for release/v6.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/v6.3
git worktree add -d .worktree/backport-2692-to-release/v6.3 origin/release/v6.3
cd .worktree/backport-2692-to-release/v6.3
git switch --create backport-2692-to-release/v6.3
git cherry-pick -x f72a9f3ae59a7da607b28012e37028f0452e6c47

jewei1997 added a commit that referenced this pull request Jan 12, 2026
(cherry picked from commit f72a9f3)
philipsu522 pushed a commit that referenced this pull request Jan 12, 2026
(cherry picked from commit f72a9f3)

## Describe your changes and provide context

## Testing performed to validate your change
cursor bot pushed a commit that referenced this pull request Jan 18, 2026
…ed transactions

This documents the root cause of trace gas check failures for failed transactions
in historical blocks. The issue is caused by the 'double refund' bug in the
go-ethereum fork that was fixed in PR #2692 (v1.15.7-sei-14).

Key findings:
- Trace gas > receipt gas for failed transactions in historical blocks
- Caused by incorrect refund application for failed transactions before the fix
- Receipts stored incorrect (lower) gas values
- Trace replay with current code correctly calculates gas (higher)

Includes recommended resolution options for validation tools.

Co-authored-by: kartik <kartik@seinetwork.io>
@Kbhat1 Kbhat1 mentioned this pull request Jan 18, 2026
@jewei1997 jewei1997 mentioned this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants