Add association for giga executor#2693
Merged
arajasek merged 4 commits intosteven/evmc-vmfrom Jan 12, 2026
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## steven/evmc-vm #2693 +/- ##
==================================================
+ Coverage 41.94% 41.96% +0.02%
==================================================
Files 1018 1018
Lines 84809 84809
==================================================
+ Hits 35569 35594 +25
+ Misses 45888 45873 -15
+ Partials 3352 3342 -10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
arajasek
approved these changes
Jan 12, 2026
utils/helpers/address.go
Outdated
|
|
||
| // RecoverSenderFromTx recovers the sender's EVM address, Sei address, and public key | ||
| // from a signed Ethereum transaction. This uses the same signature recovery logic as | ||
| // x/evm/ante/preprocess.go:Preprocess to ensure consistent results. |
Contributor
There was a problem hiding this comment.
do you want to avoid the duplication and just refactor preprocess.go to use this helper? based on a quick look, it should be doable.
arajasek
approved these changes
Jan 12, 2026
| // legacy TX needs to be adjusted based on chainID | ||
| V = new(big.Int).Sub(V, new(big.Int).Mul(chainID, utils.Big2)) | ||
| return V.Sub(V, utils.Big8) | ||
| // Version-based signer selection (same logic as PreprocessUnpacked) |
Contributor
There was a problem hiding this comment.
This comment is out-of-date, I think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change