fix: lthash worker loop break; remove unreachable digest.Read fallback#2698
Merged
blindchaser merged 2 commits intomainfrom Jan 14, 2026
Merged
fix: lthash worker loop break; remove unreachable digest.Read fallback#2698blindchaser merged 2 commits intomainfrom
blindchaser merged 2 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2698 +/- ##
=======================================
Coverage 43.82% 43.82%
=======================================
Files 1908 1908
Lines 158967 158948 -19
=======================================
Hits 69664 69664
+ Misses 82904 82885 -19
Partials 6399 6399
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
yzang2019
approved these changes
Jan 14, 2026
jewei1997
approved these changes
Jan 14, 2026
yzang2019
added a commit
that referenced
this pull request
Jan 14, 2026
* main: fix: lthash worker loop break; remove unreachable digest.Read fallback (#2698)
yzang2019
pushed a commit
that referenced
this pull request
Feb 25, 2026
#2698) ## Describe your changes and provide context - Since `start := w * chunkSize` is monotonic, we switched both loops from continue to break to avoid unnecessary iterations. - remove unreachable digest.Read fallback ## Testing performed to validate your change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
start := w * chunkSizeis monotonic, we switched both loops from continue to break to avoid unnecessary iterations.Testing performed to validate your change