Skip to content

fix: lthash worker loop break; remove unreachable digest.Read fallback#2698

Merged
blindchaser merged 2 commits intomainfrom
yiren/lthash-fix
Jan 14, 2026
Merged

fix: lthash worker loop break; remove unreachable digest.Read fallback#2698
blindchaser merged 2 commits intomainfrom
yiren/lthash-fix

Conversation

@blindchaser
Copy link
Copy Markdown
Contributor

@blindchaser blindchaser commented Jan 13, 2026

Describe your changes and provide context

  • Since start := w * chunkSize is monotonic, we switched both loops from continue to break to avoid unnecessary iterations.
  • remove unreachable digest.Read fallback

Testing performed to validate your change

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 13, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 14, 2026, 9:23 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.82%. Comparing base (7a3b6b4) to head (eb08c9d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-db/state_db/sc/flatkv/lthash/api.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2698   +/-   ##
=======================================
  Coverage   43.82%   43.82%           
=======================================
  Files        1908     1908           
  Lines      158967   158948   -19     
=======================================
  Hits        69664    69664           
+ Misses      82904    82885   -19     
  Partials     6399     6399           
Flag Coverage Δ
sei-chain 45.91% <33.33%> (+0.01%) ⬆️
sei-cosmos 38.20% <ø> (+<0.01%) ⬆️
sei-db 69.43% <ø> (ø)
sei-tendermint 47.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-db/state_db/sc/flatkv/lthash/lthash.go 91.30% <100.00%> (+12.94%) ⬆️
sei-db/state_db/sc/flatkv/lthash/api.go 85.71% <0.00%> (ø)

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blindchaser blindchaser changed the title fix: lthash for loop fix: lthash fix worker loop break; remove unreachable fallback Jan 14, 2026
@blindchaser blindchaser changed the title fix: lthash fix worker loop break; remove unreachable fallback fix: lthash worker loop break; remove unreachable digest.Read fallback Jan 14, 2026
@blindchaser blindchaser merged commit ad3dac7 into main Jan 14, 2026
41 of 42 checks passed
@blindchaser blindchaser deleted the yiren/lthash-fix branch January 14, 2026 22:21
yzang2019 added a commit that referenced this pull request Jan 14, 2026
* main:
  fix: lthash worker loop break; remove unreachable digest.Read fallback (#2698)
yzang2019 pushed a commit that referenced this pull request Feb 25, 2026
#2698)

## Describe your changes and provide context

- Since `start := w * chunkSize` is monotonic, we switched both loops
from continue to break to avoid unnecessary iterations.
- remove unreachable digest.Read fallback
 
## Testing performed to validate your change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants