Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pd/evmc-vm #2699 +/- ##
==============================================
- Coverage 43.69% 41.94% -1.76%
==============================================
Files 1911 1017 -894
Lines 159430 84784 -74646
==============================================
- Hits 69670 35565 -34105
+ Misses 83360 45875 -37485
+ Partials 6400 3344 -3056
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
stevenlanders
approved these changes
Jan 14, 2026
arajasek
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Refactor of the
evmcandgethVM.First an improvement on the abstraction - we're working on transaction executor level, not on the VM level.
Second, we can leverage the same executor implementation to cover both
evmoneandgethcases.Removing everything that's redundant since second point holds true.
Testing performed to validate your change
Ran
giga/tests.