Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2708 +/- ##
==========================================
+ Coverage 52.41% 56.81% +4.40%
==========================================
Files 1022 2004 +982
Lines 84800 164794 +79994
==========================================
+ Hits 44446 93624 +49178
- Misses 36226 62948 +26722
- Partials 4128 8222 +4094
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
arajasek
force-pushed
the
asr/rpc-giga
branch
from
f8f0311 to
cf9251a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| func (app *App) ProcessTxsSynchronousGiga(ctx sdk.Context, txs [][]byte, typedTxs []sdk.Tx, absoluteTxIndices []int) []*abci.ExecTxResult { | ||
| defer metrics.BlockProcessLatency(time.Now(), metrics.SYNCHRONOUS) |
Check warning
Code scanning / CodeQL
Calling the system time Warning
arajasek
force-pushed
the
asr/rpc-giga
branch
from
cf9251a to
0124cc8
Compare
arajasek
force-pushed
the
asr/rpc-giga
branch
12 times, most recently
from
b8763f8 to
130c3e5
Compare
arajasek
changed the title
stevenlanders
approved these changes
Jan 21, 2026
arajasek
force-pushed
the
asr/rpc-giga
branch
2 times, most recently
from
5547872 to
9ff6ef2
Compare
codchen
reviewed
Jan 26, 2026
| } | ||
| continue | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
would need to call ctx.GigaMultiStore().WriteGiga() here since giga cache isn't visible to v2 executor so need flushing
arajasek
force-pushed
the
asr/rpc-giga
branch
3 times, most recently
from
5394e39 to
41ecdbc
Compare
codchen
approved these changes
Jan 27, 2026
arajasek
force-pushed
the
asr/rpc-giga
branch
from
12e8172 to
a23d40f
Compare
- Set the txIndex correctly (ProcessBlock already does this) - Return ABCI codes
arajasek
force-pushed
the
asr/rpc-giga
branch
from
a23d40f to
1329116
Compare
arajasek
added a commit
that referenced
this pull request
Feb 5, 2026
This is a followup to #2708 adding support for OCC mode to Giga RPC nodes. The logic is: - Make a list of EVM txs and non-EVM txs - Run EVM txs in parallel - If they fail due to interop, throw away all your work and just use the v2 logic for ALL txs - Run non-EVM txs in parallel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR supports running a Giga node, in consensus with other non-Giga nodes. It only supports sequential execution for Giga, falling back to the v2 logic for cosmos and interop transactions.
TODO:
Testing performed to validate your change