Skip to content

Backport release/v6.4: Fix IBC Upgrade Params#3093

Merged
masih merged 1 commit intorelease/v6.4from
backport-3092-to-release/v6.4
Mar 20, 2026
Merged

Backport release/v6.4: Fix IBC Upgrade Params#3093
masih merged 1 commit intorelease/v6.4from
backport-3092-to-release/v6.4

Conversation

@seidroid
Copy link
Copy Markdown

@seidroid seidroid bot commented Mar 20, 2026

Backport of #3092 to release/v6.4.

## Describe your changes and provide context
- Bump the IBC module consensus version
- Initialize the new inbound/outbound params in migration so upgrades do
not panic

## Testing performed to validate your change
- Unit tests
- Verified full upgrade on node

Before
```
github.com/sei-protocol/sei-chain/sei-cosmos/x/upgrade.panicUpgradeNeeded({{_, _}, _, {_, _}, {_, _}, _, {_, _}, ...}, ...)
	/tmp/sei-upgrade/old-src/sei-cosmos/x/upgrade/abci.go:111 +0x1a0
github.com/sei-protocol/sei-chain/sei-cosmos/x/upgrade.BeginBlocker({{_, _}, _, {_, _}, {_, _}, _, {_, _}, ...}, ...)
	/tmp/sei-upgrade/old-src/sei-cosmos/x/upgrade/abci.go:68 +0x77c
```

After
```
time=2026-03-19T23:16:05.942-04:00 level=INFO msg="applying upgrade" logger=cosmos/x/upgrade name=v6.4.0 at="height: 51"
time=2026-03-19T23:16:05.942-04:00 level=INFO msg="migrating module from version to version" logger=cosmos/types/module module=ibc from-version=2 to-version=3
```

Query
```
$ seid q params subspace ibc InboundEnabled --output json
{"subspace":"ibc","key":"InboundEnabled","value":"true"}

$ seid q params subspace ibc OutboundEnabled --output json
{"subspace":"ibc","key":"OutboundEnabled","value":"true"}
```

(cherry picked from commit 1ee46bf)
@seidroid seidroid bot added the backport label Mar 20, 2026
@seidroid seidroid bot mentioned this pull request Mar 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 20, 2026, 9:26 AM

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.44%. Comparing base (dcdde1b) to head (3dcc69b).
⚠️ Report is 1 commits behind head on release/v6.4.

Files with missing lines Patch % Lines
sei-ibc-go/modules/core/module.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release/v6.4    #3093   +/-   ##
=============================================
  Coverage         58.43%   58.44%           
=============================================
  Files              2088     2088           
  Lines            172084   172082    -2     
=============================================
+ Hits             100559   100566    +7     
+ Misses            62599    62589   -10     
- Partials           8926     8927    +1     
Flag Coverage Δ
sei-chain-pr 48.72% <71.42%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/upgrades.go 26.82% <ø> (+3.91%) ⬆️
sei-ibc-go/modules/core/keeper/migrations.go 50.00% <100.00%> (+50.00%) ⬆️
sei-ibc-go/modules/core/module.go 49.39% <50.00%> (-1.22%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih enabled auto-merge (squash) March 20, 2026 09:30
@masih masih disabled auto-merge March 20, 2026 09:51
@masih masih merged commit 8506bcf into release/v6.4 Mar 20, 2026
45 of 47 checks passed
@masih masih deleted the backport-3092-to-release/v6.4 branch March 20, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants