Skip to content

Fix SIGSEGV in historical RPC queries #3098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masih merged 1 commit into from
Mar 20, 2026
Merged

Fix SIGSEGV in historical RPC queries #3098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions sei-cosmos/storev2/rootmulti/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,19 @@ func (rs *Store) Query(req abci.RequestQuery) abci.ResponseQuery {

res := store.Query(req)

// When serving from a historical read-only memiavl instance, the response
// byte slices (Key, Value) may point directly into mmap'd memory that will
// be unmapped when the deferred scStore.Close() runs. Copy them so the
// caller doesn't hit a use-after-free segfault during JSON marshaling.
if !latest {
if len(res.Key) > 0 {
res.Key = append([]byte{}, res.Key...)
}
if len(res.Value) > 0 {
res.Value = append([]byte{}, res.Value...)
}
}

// If underlying query failed (e.g. invalid height/path) or doesn' need proof, return as-is.
if res.Code != 0 || !needProof {
return res
Expand Down
Loading