Guard LastCommitID with rootmulti read lock#3184
Merged
Conversation
Race Detection was intermittently failing in sei-cosmos/client/rpc because Status -> ABCIInfo -> BaseApp.Info called rootmulti.Store.LastCommitID while Commit was updating lastCommitInfo under rs.mtx. Use the existing RWMutex for LastCommitID reads so integration test startup polling no longer races with block commits.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
blindchaser
approved these changes
Apr 3, 2026
bdchatham
approved these changes
Apr 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3184 +/- ##
=======================================
Coverage 58.69% 58.69%
=======================================
Files 2055 2055
Lines 168379 168381 +2
=======================================
+ Hits 98830 98832 +2
Misses 60737 60737
Partials 8812 8812
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
yzang2019
approved these changes
Apr 3, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2026
Race Detection was intermittently failing in sei-cosmos/client/rpc because Status -> ABCIInfo -> BaseApp.Info called rootmulti.Store.LastCommitID while Commit was updating lastCommitInfo under rs.mtx. Use the existing RWMutex for LastCommitID reads so integration test startup polling no longer races with block commits. (cherry picked from commit f93771a)
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Race Detection was intermittently failing in sei-cosmos/client/rpc because
Status -> ABCIInfo -> BaseApp.Info called rootmulti.Store.LastCommitID
while Commit was updating lastCommitInfo under rs.mtx.
Use the existing RWMutex for LastCommitID reads so integration test startup
polling no longer races with block commits.