fix(sei-tendermint): resolve staticcheck warnings#3207
Merged
amir-deris merged 3 commits intomainfrom Apr 8, 2026
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3207 +/- ##
==========================================
- Coverage 58.92% 58.82% -0.11%
==========================================
Files 2060 2054 -6
Lines 168733 168215 -518
==========================================
- Hits 99433 98945 -488
+ Misses 60592 60536 -56
- Partials 8708 8734 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
masih
approved these changes
Apr 8, 2026
yzang2019
added a commit
that referenced
this pull request
Apr 9, 2026
* main: Add receipt / log reads to cryptosim (#3081) persist blocks and FullCommitQCs in data layer via WAL (CON-231) (#3126) Update Changelog in prep to cut v6.4.1 (#3213) fix(sei-tendermint): resolve staticcheck warnings (#3207) Add historical state offload stream hook (#3183) feat: wire autobahn config propagation from top-level to GigaRouter (CON-232) (#3194)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves some of the staticcheck warnings in the
sei-tendermintpackage by removing unused code and fixing unchecked errors.sha256trunctype,bindFlagsLoadViper,validateOutput,interfaceWrapper,sortedCopy,containsAny,containsAll,contains, unused constants (BlockSize,TruncatedSize), androuterRestartChfieldidx,val,addr,sender,maxIn)require.NoErrorfor errors previously silently ignored inreactor_test.goandstate_test.goextCommitKeywith a lint ignore directive