Skip to content

fix(sei-tendermint): resolve staticcheck warnings#3207

Merged
amir-deris merged 3 commits intomainfrom
amir/PLT-249-fix-static-check-in-sei-tendermint-package
Apr 8, 2026
Merged

fix(sei-tendermint): resolve staticcheck warnings#3207
amir-deris merged 3 commits intomainfrom
amir/PLT-249-fix-static-check-in-sei-tendermint-package

Conversation

@amir-deris
Copy link
Copy Markdown
Contributor

@amir-deris amir-deris commented Apr 7, 2026

Summary

Resolves some of the staticcheck warnings in the sei-tendermint package by removing unused code and fixing unchecked errors.

  • Removed dead code: sha256trunc type, bindFlagsLoadViper, validateOutput, interfaceWrapper, sortedCopy, containsAny, containsAll, contains, unused constants (BlockSize, TruncatedSize), and routerRestartCh field
  • Fixed unused variables in tests (idx, val, addr, sender, maxIn)
  • Added missing require.NoError for errors previously silently ignored in reactor_test.go and state_test.go
  • Suppressed false positive for extCommitKey with a lint ignore directive

@amir-deris amir-deris self-assigned this Apr 7, 2026
@amir-deris amir-deris changed the title fixed some of static check warnings in sei-tendermint package fix(sei-tendermint): resolve staticcheck warnings Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 8, 2026, 4:50 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.82%. Comparing base (36f9664) to head (809bd9d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3207      +/-   ##
==========================================
- Coverage   58.92%   58.82%   -0.11%     
==========================================
  Files        2060     2054       -6     
  Lines      168733   168215     -518     
==========================================
- Hits        99433    98945     -488     
+ Misses      60592    60536      -56     
- Partials     8708     8734      +26     
Flag Coverage Δ
sei-chain-pr 73.81% <ø> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/crypto/tmhash/hash.go 60.00% <ø> (+41.25%) ⬆️
sei-tendermint/internal/store/store.go 59.94% <ø> (ø)
sei-tendermint/libs/cli/setup.go 58.18% <ø> (+14.93%) ⬆️
sei-tendermint/libs/json/decoder.go 73.45% <ø> (ø)
sei-tendermint/node/node.go 59.36% <ø> (ø)
sei-tendermint/types/tx.go 91.42% <ø> (+21.86%) ⬆️

... and 61 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amir-deris amir-deris requested review from bdchatham and masih April 7, 2026 19:49
Copy link
Copy Markdown

@bdchatham bdchatham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amir-deris amir-deris added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit d822319 Apr 8, 2026
39 checks passed
@amir-deris amir-deris deleted the amir/PLT-249-fix-static-check-in-sei-tendermint-package branch April 8, 2026 20:17
yzang2019 added a commit that referenced this pull request Apr 9, 2026
* main:
  Add receipt / log reads to cryptosim (#3081)
  persist blocks and FullCommitQCs in data layer via WAL (CON-231) (#3126)
  Update Changelog in prep to cut v6.4.1 (#3213)
  fix(sei-tendermint): resolve staticcheck warnings (#3207)
  Add historical state offload stream hook (#3183)
  feat: wire autobahn config propagation from top-level to GigaRouter (CON-232) (#3194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants