Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3209 +/- ##
=======================================
Coverage 58.79% 58.79%
=======================================
Files 2054 2054
Lines 168303 168305 +2
=======================================
+ Hits 98948 98952 +4
+ Misses 60609 60608 -1
+ Partials 8746 8745 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
pompon0
changed the title
sei-will
approved these changes
Apr 8, 2026
wen-coding
approved these changes
Apr 9, 2026
| err := mux.Run(ctx, c2) | ||
| t.Logf("mux terminated: %v", err) | ||
| if !errors.Is(err, errAlreadyOpened) { | ||
| return fmt.Errorf("err = %v, want %v", err, errTooManyMsgs) |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("err = %v, want %v", err, errTooManyMsgs) | |
| return fmt.Errorf("err = %v, want %v", err, errAlreadyOpened) |
| err := mux.Run(ctx, c2) | ||
| t.Logf("mux terminated: %v", err) | ||
| if !errors.Is(err, errAlreadyOpened) { | ||
| return fmt.Errorf("err = %v, want %v", err, errTooManyMsgs) |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("err = %v, want %v", err, errTooManyMsgs) | |
| return fmt.Errorf("err = %v, want %v", err, errAlreadyOpened) |
| err := mux.Run(ctx, c2) | ||
| t.Logf("mux terminated: %v", err) | ||
| if !errors.Is(err, errUnknownStream) { | ||
| return fmt.Errorf("err = %v, want %v", err, errTooManyAccepts) |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("err = %v, want %v", err, errTooManyAccepts) | |
| return fmt.Errorf("err = %v, want %v", err, errUnknownStream) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made mux stream opening more strict:
Added relevant tests.