Closed
Conversation
eric-zhu-uw
requested review from
BrandonWeng and
udpatil
and removed request for
BrandonWeng
Contributor
|
Contributor
Author
Yes, there is some interaction with the module account, For example, for Not certain if this is the best way, might be better to be more granular if there is ever a time where we might access the validator and not their corresponding module accounts or vice versa. |
eric-zhu-uw
commented
Oct 24, 2022
| // Checks if there is a delegation object that already exists for (delegatorAddr, validatorAddr) | ||
| { | ||
| AccessType: sdkacltypes.AccessType_READ, | ||
| ResourceType: sdkacltypes.ResourceType_KV, |
Contributor
Author
There was a problem hiding this comment.
This and subsequent mappings will need to be updated to sdkacltypes.ResourceType_KV_STAKING_* once uday's PR gets merged.
BrandonWeng
reviewed
Oct 24, 2022
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context - Adds a basic scheduler shell (see TODOs) - Adds a basic task definition with request/response/index - Listens to abort channel after an execution to determine conflict ## Testing performed to validate your change - Compiles (holding off until shape is validated) - Basic Unit Test for ProcessAll
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context - Adds a basic scheduler shell (see TODOs) - Adds a basic task definition with request/response/index - Listens to abort channel after an execution to determine conflict ## Testing performed to validate your change - Compiles (holding off until shape is validated) - Basic Unit Test for ProcessAll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Added staking dep gen mappings.
Testing performed to validate your change
Ran loadtesting on a distribution of
Delegate, Undelegate, BeginRedelegatemessagesVerified the following details:
seid q block | jq ".block.last_commit.height"which implies a consensus is reached and the validators agree on an apphashDelegationmessage correctly submits the delegations for validator, account pairingseid query staking delegations-to <validator_addr>UndelegateandBeginRedelegatemessages are correctly submitted. This is a little more tricky to test since the delegation will only stay in theUnbonding,Redelegatestate for a short period of time. However, you can verify this immediately after you run the loadtest script withseid query staking redelegations-from <validator_addr>andseid query staking unbonding-delegations-from <validator_addr>.If you want to try and test the changes locally, utilize my
sei-infrabranch.To Do
2.0.0betasei-cosmosbranch needs to merge into his branch.