Use slice based loop instead of map based loop in Begin/EndBlock#33
Merged
Use slice based loop instead of map based loop in Begin/EndBlock#33
Conversation
LCyson
approved these changes
Jun 5, 2022
Contributor
LCyson
left a comment
LCyson
left a comment
There was a problem hiding this comment.
lgtm, can we add some test sets to dex endBlock so that if there is any non-determinism in the future the CI will fail
codchen
force-pushed
the
tony-chen-remove-map-loop
branch
from
3cb79a6 to
dece160
Compare
Collaborator
Author
|
@LCyson added a test for idempotency |
masih
pushed a commit
that referenced
this pull request
Sep 26, 2025
Replace cosmos/tendermint/iavl/tmdb/ibc dependencies with forked versions
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
Adding a handler for handling gov proposals from CLI in order to update the dependency mappings for access control module. Will follow up with another PR to handle deletes ### Testing Ran these commands and see that the dep mapping updated ``` seid tx staking delegate seivaloper1r9syjw4kdpjr8a6v38qmvn4dmmrnl869kmgsvr 59999000001341816640usei --from brando --chain-id sei-chain -b block -y --fees 2000usei seid tx gov submit-proposal update-resource-dependency-mapping ../brando/acl-gov.json --from brando --fees=10000000usei --gas=5000000 --chain-id sei-chain -b block seid tx gov deposit 1 10000000usei --chain-id sei-chain --from brando --fees=10000000usei --gas=5000000 -b block -y seid tx gov vote 1 yes --chain-id sei-chain --from brando -b block -y --fees=10000000usei ``` 
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
Adding a handler for handling gov proposals from CLI in order to update the dependency mappings for access control module. Will follow up with another PR to handle deletes ### Testing Ran these commands and see that the dep mapping updated ``` seid tx staking delegate seivaloper1r9syjw4kdpjr8a6v38qmvn4dmmrnl869kmgsvr 59999000001341816640usei --from brando --chain-id sei-chain -b block -y --fees 2000usei seid tx gov submit-proposal update-resource-dependency-mapping ../brando/acl-gov.json --from brando --fees=10000000usei --gas=5000000 --chain-id sei-chain -b block seid tx gov deposit 1 10000000usei --chain-id sei-chain --from brando --fees=10000000usei --gas=5000000 -b block -y seid tx gov vote 1 yes --chain-id sei-chain --from brando -b block -y --fees=10000000usei ``` 
masih
pushed a commit
that referenced
this pull request
Oct 1, 2025
masih
pushed a commit
that referenced
this pull request
Oct 9, 2025
Perf: Improve memIAVL import speed by 2X
masih
pushed a commit
that referenced
this pull request
Dec 17, 2025
Synchronize potential concurrent access to mutable tree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of looping over a map, we will fetch a slice of registered pairs first, and then iterate over the slice and get map's value keyed by each pair, so that the iteration is deterministic.