Charge gas from registered contract rent for dex sudo calls#365
Merged
Charge gas from registered contract rent for dex sudo calls#365
Conversation
LCyson
approved these changes
Nov 4, 2022
codchen
force-pushed
the
tony-chen-charge-gas
branch
from
e0a9767 to
17a5d20
Compare
codchen
force-pushed
the
tony-chen-charge-gas
branch
from
17a5d20 to
4a4e938
Compare
philipsu522
pushed a commit
that referenced
this pull request
Nov 14, 2022
* Charge gas from contract rent for sudo calls * lint * whitelist contract info key * rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
When a sudo call is made for a dex registered contract, we will charge gas for it from the contract's rent.
dexwill not process a contract whose rent drops to 0, since any processing involves sudo calls.Testing performed to validate your change
unit tests
tested on local set