Conversation
philipsu522
approved these changes
Jun 11, 2022
LCyson
reviewed
Jun 11, 2022
| for _, orderPlacement := range orderPlacements.Orders { | ||
| if !orderPlacement.Liquidation { | ||
| contractOrderPlacements = append(contractOrderPlacements, dexcache.ToContractOrderPlacement(orderPlacement)) | ||
| if len(contractOrderPlacements) == MAX_ORDERS_PER_SUDO_CALL { |
Contributor
There was a problem hiding this comment.
here if the number of contractOrderPlacements doesn't reach 50000 here, is the contractOrderPlacements discarded then?
Contributor
There was a problem hiding this comment.
can we add a unit test for this one^
codchen
force-pushed
the
tony-chen-fix-loadtest
branch
from
6dba94f to
4c825e7
Compare
masih
pushed a commit
that referenced
this pull request
Sep 26, 2025
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context There are resource accesses in the ante handler, we need to block before the access occurs, or else we will run into issues there where there's a race condition between the different accesses ## Testing performed to validate your change Ran 20 iterations of the the basic msg load test with 5 validators and didn't experience any issues
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context There are resource accesses in the ante handler, we need to block before the access occurs, or else we will run into issues there where there's a race condition between the different accesses ## Testing performed to validate your change Ran 20 iterations of the the basic msg load test with 5 validators and didn't experience any issues
masih
pushed a commit
that referenced
this pull request
Oct 1, 2025
…s #7781" (#40) Fix state sync failure caused by duplicates RPC endpoints providers Co-authored-by: Yiming Zang <yzang@twitter.com>
masih
pushed a commit
that referenced
this pull request
Oct 9, 2025
[SeiDB] Pt 2 State Store Unit Tests
masih
pushed a commit
that referenced
this pull request
Oct 23, 2025
Return unit64 based timestamp in packet timeout error message
masih
pushed a commit
that referenced
this pull request
Dec 17, 2025
Fix nil interface conversion error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix scripts used by loadtest to work with sequence numbers properly. Tested on local chain with 1000 accounts.