Conversation
codchen
approved these changes
Jun 15, 2022
philipsu522
reviewed
Jun 15, 2022
x/oracle/keeper/keeper.go
Outdated
| }) | ||
|
|
||
| // iterate over all denoms with TWAP data | ||
| for denomKey := range denomToTimeWeightedMap { |
Contributor
There was a problem hiding this comment.
let's be careful here - we're iterating over a map which can be nondeterministic. I think it should be ok since this isn't saving to state, but it might still be safer to somehow store the keys in a list, sort then iterate based on that in case we decide to use this in the future for saving to state
Collaborator
Author
There was a problem hiding this comment.
sure yeah, I'll collect denoms in a sorted list prior to iterating and outputting twaps 👍
| denomTimeWeightedSum := denomToTimeWeightedMap[denom] | ||
| denomDuration := denomDurationMap[denom] | ||
|
|
||
| // calculate the new Time Weighted Sum for the denom exchange rate |
Contributor
There was a problem hiding this comment.
do you mind adding a comment here including the twap formula?
…apshot if no data to snapshot
Collaborator
Author
|
@philipsu522 I addressed the feedback 👍 |
philipsu522
approved these changes
Jun 16, 2022
masih
pushed a commit
that referenced
this pull request
Sep 26, 2025
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context This adds the antedeps generated to the graph prior to adding message deps. ## Testing performed to validate your change
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context This adds the antedeps generated to the graph prior to adding message deps. ## Testing performed to validate your change
masih
pushed a commit
that referenced
this pull request
Oct 1, 2025
masih
pushed a commit
that referenced
this pull request
Oct 9, 2025
[SeiDB] Fix PebbleDB Iterator Issue
masih
pushed a commit
that referenced
this pull request
Nov 21, 2025
Added replace directives and fixed build errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for the oracle TWAP stuff on top of the price history snapshots. Putting it out for review, but will modify PR to merge to master after the prior PR is merged.