Refund gas fees if concurrent TX fails#444
Merged
BrandonWeng merged 4 commits intomasterfrom Dec 3, 2022
Merged
Conversation
BrandonWeng
force-pushed
the
bweng-ctx-cache
branch
from
3404038 to
661be14
Compare
BrandonWeng
force-pushed
the
bweng-ctx-cache
branch
from
661be14 to
d1d4f79
Compare
udpatil
reviewed
Dec 2, 2022
app/app.go
Outdated
|
|
||
| ctx.Logger().Error("Concurrent Execution failed, retrying with Synchronous") | ||
| // Clear the memcache context from the previous state as it failed, we no longer need to commit the data | ||
| ctx = ctx.WithContextMemCache(sdk.NewContextMemCache()) |
Collaborator
There was a problem hiding this comment.
just to confirm, is this the step that we need in order to reset the in memory state prior to rerunning txs synchronously?
Contributor
Author
There was a problem hiding this comment.
Yes, this resets the state for the rerun of TXs synchronously
udpatil
reviewed
Dec 2, 2022
| ctx sdk.Context, | ||
| txs [][]byte, | ||
| dependencyDag *acltypes.Dag, | ||
| processBlockConcurrentFunction ProcessBlockConcurrentFunction, |
Collaborator
There was a problem hiding this comment.
why do we pass the the function instead of directly calling the ProcessBlockConcurrent? is it primarily for the mocking purposes in testing? if so, isn't that an antipattern? (I don't have strong feelings one way or the other on whether we keep it this way, just looking to better understand this & golang best practices.
Contributor
Author
There was a problem hiding this comment.
Yeah, this is mainly for testing, I was following this: https://www.myhatchpad.com/insight/mocking-techniques-for-go/
udpatil
approved these changes
Dec 2, 2022
philipsu522
reviewed
Dec 2, 2022
app/app_test.go
Outdated
| Denom: "test", | ||
| Amount: sdk.NewInt(1), | ||
| })) | ||
| // It should be reset if it fails to prevent any values from being written |
Contributor
There was a problem hiding this comment.
is this comment correct? i think the function succeeds?
philipsu522
approved these changes
Dec 2, 2022
BrandonWeng
added a commit
to sei-protocol/sei-cosmos
that referenced
this pull request
Dec 3, 2022
## Describe your changes and provide context Adds a method for us to reset the cache instead of creating a new one. Makes it easier for testing ## Testing performed to validate your change For this PR: sei-protocol/sei-chain#444
|
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context Adds a method for us to reset the cache instead of creating a new one. Makes it easier for testing ## Testing performed to validate your change For this PR: #444
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context This adds CI to seiv2 branch ## Testing performed to validate your change CI
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context Adds a method for us to reset the cache instead of creating a new one. Makes it easier for testing ## Testing performed to validate your change For this PR: #444
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context This adds CI to seiv2 branch ## Testing performed to validate your change CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
We already reset the cacheKv (by not writing it) if the transactions fail, but we also need to reset the in-mem values to as those are different from the store
Previously we didn't clear the state so the deferred sends from the previous call carried over
Testing performed to validate your change
Unit tests