Conversation
|
Contributor
Author
|
@philipsu522 I updated with the change to remove password requirement, and added some instructions for how to submit a proposal. Please take another look, thanks! |
philipsu522
approved these changes
Dec 19, 2022
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context Add two new metrics for StoreV2: - Add metric to monitor SC commit latency - Add metric to monitor SS store last commit version ## Testing performed to validate your change Tested locally and see metrics appear
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context Add two new metrics for StoreV2: - Add metric to monitor SC commit latency - Add metric to monitor SS store last commit version ## Testing performed to validate your change Tested locally and see metrics appear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Problem:
Initialize_local.sh is broken on Mac because sed command is not working on latest MacOS:
Fix:
sed is little bit different on Mac compared to Linux GNU, we need to change the command to this
sed -i'.bak' -e 's/something/else'g' filepathTesting performed to validate your change
Tested on Mac and Ubuntu