Skip to content

Update default configs for consenssus TM and bump version for new defaults #480

Merged
BrandonWeng merged 11 commits intomasterfrom
sei-2483
Jan 6, 2023
Merged

Update default configs for consenssus TM and bump version for new defaults #480
BrandonWeng merged 11 commits intomasterfrom
sei-2483

Conversation

@BrandonWeng
Copy link
Contributor

Describe your changes and provide context

Testing performed to validate your change

image

config.Consensus.UnsafeProposeTimeoutOverride = 250 * time.Millisecond
config.Consensus.UnsafeVoteTimeoutOverride = 250 * time.Millisecond
config.Consensus.UnsafeCommitTimeoutOverride = 250 * time.Millisecond
config.Consensus.GossipTransactionKeyOnly = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overrides the default in TM

override_genesis '.app_state["slashing"]["params"]["signed_blocks_window"]="10000"'
override_genesis '.app_state["slashing"]["params"]["min_signed_per_window"]="0.050000000000000000"'
override_genesis '.app_state["staking"]["params"]["max_validators"]="50"'
override_genesis '.consensus_params["block"]["time_iota_ms"]="1"'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field was removed in our version of TM actually

Comment on lines -60 to -79
if [[ "$OSTYPE" == "linux-gnu"* ]]; then
sed -i 's/timeout_prevote =.*/timeout_prevote = "2000ms"/g' $CONFIG_PATH
sed -i 's/timeout_precommit =.*/timeout_precommit = "2000ms"/g' $CONFIG_PATH
sed -i 's/timeout_commit =.*/timeout_commit = "2000ms"/g' $CONFIG_PATH
sed -i 's/skip_timeout_commit =.*/skip_timeout_commit = false/g' $CONFIG_PATH
elif [[ "$OSTYPE" == "darwin"* ]]; then
sed -i '' 's/# unsafe-propose-timeout-override = 0s =.*/unsafe-propose-timeout-override = "10s"/g' $CONFIG_PATH
sed -i '' 's/# unsafe-propose-timeout-delta-override = 0s =.*/unsafe-propose-timeout-delta-override = "10s"/g' $CONFIG_PATH
sed -i '' 's/# unsafe-vote-timeout-override = 0s =.*/unsafe-vote-timeout-override = "10s"/g' $CONFIG_PATH
sed -i '' 's/# unsafe-vote-timeout-delta-override = 0s =.*/unsafe-vote-timeout-delta-override = "10s"/g' $CONFIG_PATH
sed -i '' 's/# unsafe-commit-timeout-override = 0s =.*/unsafe-commit-timeout-override = "10s"/g' $CONFIG_PATH
else
printf "Platform not supported, please ensure that the following values are set in your config.toml:\n"
printf "### Consensus Configuration Options ###\n"
printf "\t timeout_prevote = \"2000ms\"\n"
printf "\t timeout_precommit = \"2000ms\"\n"
printf "\t timeout_commit = \"2000ms\"\n"
printf "\t skip_timeout_commit = false\n"
exit 1
fi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't been working

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Code Coverage

Package Line Rate Complexity Health
github.com/sei-protocol/sei-chain/aclmapping/bank 100% 0
github.com/sei-protocol/sei-chain/aclmapping/dex 97% 0
github.com/sei-protocol/sei-chain/aclmapping/oracle 100% 0
github.com/sei-protocol/sei-chain/aclmapping/staking 82% 0
github.com/sei-protocol/sei-chain/aclmapping/tokenfactory 96% 0
github.com/sei-protocol/sei-chain/aclmapping/utils 0% 0
github.com/sei-protocol/sei-chain/aclmapping/wasm 83% 0
github.com/sei-protocol/sei-chain/app 59% 0
github.com/sei-protocol/sei-chain/app/antedecorators 74% 0
github.com/sei-protocol/sei-chain/oracle/price-feeder/config 85% 0
github.com/sei-protocol/sei-chain/oracle/price-feeder/oracle 73% 0
github.com/sei-protocol/sei-chain/oracle/price-feeder/oracle/provider 50% 0
github.com/sei-protocol/sei-chain/oracle/price-feeder/router/v1 45% 0
github.com/sei-protocol/sei-chain/store/whitelist/cachemulti 100% 0
github.com/sei-protocol/sei-chain/store/whitelist/kv 100% 0
github.com/sei-protocol/sei-chain/store/whitelist/multi 100% 0
github.com/sei-protocol/sei-chain/utils 46% 0
github.com/sei-protocol/sei-chain/utils/datastructures 90% 0
github.com/sei-protocol/sei-chain/x/dex 58% 0
github.com/sei-protocol/sei-chain/x/dex/cache 86% 0
github.com/sei-protocol/sei-chain/x/dex/client/cli/query 23% 0
github.com/sei-protocol/sei-chain/x/dex/contract 51% 0
github.com/sei-protocol/sei-chain/x/dex/exchange 89% 0
github.com/sei-protocol/sei-chain/x/dex/keeper 67% 0
github.com/sei-protocol/sei-chain/x/dex/keeper/abci 30% 0
github.com/sei-protocol/sei-chain/x/dex/keeper/msgserver 78% 0
github.com/sei-protocol/sei-chain/x/dex/keeper/query 82% 0
github.com/sei-protocol/sei-chain/x/dex/migrations 87% 0
github.com/sei-protocol/sei-chain/x/dex/types 1% 0
github.com/sei-protocol/sei-chain/x/dex/types/utils 100% 0
github.com/sei-protocol/sei-chain/x/dex/types/wasm 83% 0
github.com/sei-protocol/sei-chain/x/epoch 11% 0
github.com/sei-protocol/sei-chain/x/epoch/keeper 66% 0
github.com/sei-protocol/sei-chain/x/epoch/types 2% 0
github.com/sei-protocol/sei-chain/x/mint 0% 0
github.com/sei-protocol/sei-chain/x/mint/keeper 75% 0
github.com/sei-protocol/sei-chain/x/mint/simulation 95% 0
github.com/sei-protocol/sei-chain/x/mint/types 2% 0
github.com/sei-protocol/sei-chain/x/nitro/client/cli 45% 0
github.com/sei-protocol/sei-chain/x/nitro/keeper 80% 0
github.com/sei-protocol/sei-chain/x/nitro/replay 63% 0
github.com/sei-protocol/sei-chain/x/oracle 64% 0
github.com/sei-protocol/sei-chain/x/oracle/keeper 82% 0
github.com/sei-protocol/sei-chain/x/oracle/simulation 18% 0
github.com/sei-protocol/sei-chain/x/oracle/types 3% 0
github.com/sei-protocol/sei-chain/x/tokenfactory/keeper 85% 0
github.com/sei-protocol/sei-chain/x/tokenfactory/types 2% 0
Summary 15% (5056 / 33907) 0

@BrandonWeng BrandonWeng merged commit 5512455 into master Jan 6, 2023
@BrandonWeng BrandonWeng deleted the sei-2483 branch January 6, 2023 15:08
masih pushed a commit that referenced this pull request Sep 29, 2025
## Describe your changes and provide context
- adds new error 

## Testing performed to validate your change
- unit on sei-chain
masih pushed a commit that referenced this pull request Sep 30, 2025
## Describe your changes and provide context
- adds new error 

## Testing performed to validate your change
- unit on sei-chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants