Skip to content

Update consensus configs to be less strict #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrandonWeng merged 4 commits into from
Jan 13, 2023
Merged

Update consensus configs to be less strict #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e343a68
done
BrandonWeng Jan 12, 2023
09e33af
done
BrandonWeng Jan 12, 2023
6c86d3b
done
BrandonWeng Jan 12, 2023
3649f1c
Update config.go
BrandonWeng Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/params/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ const (
Bech32PrefixAccAddr = "sei"
)

var UnsafeBypassCommitTimeoutOverride = true
// UnsafeBypassCommitTimeoutOverride commits block as soon as we reach consensus instead of waiting
// for timeout, this may cause validators to not get their votes in time
var UnsafeBypassCommitTimeoutOverride = false

var (
// Bech32PrefixAccPub defines the Bech32 prefix of an account's public key.
Expand Down Expand Up @@ -91,13 +93,11 @@ func SetTendermintConfigs(config *tmcfg.Config) {
config.Mempool.MaxTxBytes = 2048576
// Consensus Configs
config.Consensus.GossipTransactionKeyOnly = true
config.Consensus.UnsafeProposeTimeoutOverride = 1 * time.Second
config.Consensus.UnsafeProposeTimeoutOverride = 5 * time.Second
config.Consensus.UnsafeProposeTimeoutDeltaOverride = 500 * time.Millisecond

config.Consensus.UnsafeVoteTimeoutOverride = 50 * time.Millisecond
config.Consensus.UnsafeVoteTimeoutDeltaOverride = 500 * time.Millisecond
config.Consensus.UnsafeCommitTimeoutOverride = 50 * time.Millisecond

config.Consensus.UnsafeBypassCommitTimeoutOverride = &UnsafeBypassCommitTimeoutOverride
// Metrics
config.Instrumentation.Prometheus = true
Expand Down
4 changes: 2 additions & 2 deletions x/oracle/simulation/operations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func WeightedOperations(
}

// SimulateMsgAggregateExchangeRateVote generates a MsgAggregateExchangeRateVote with random values.
//nolint: funlen
// nolint: funlen
func SimulateMsgAggregateExchangeRateVote(ak types.AccountKeeper, bk types.BankKeeper, k keeper.Keeper) simtypes.Operation {
return func(
r *rand.Rand, app *baseapp.BaseApp, ctx sdk.Context, accs []simtypes.Account, chainID string,
Expand Down Expand Up @@ -122,7 +122,7 @@ func SimulateMsgAggregateExchangeRateVote(ak types.AccountKeeper, bk types.BankK
}

// SimulateMsgDelegateFeedConsent generates a MsgDelegateFeedConsent with random values.
//nolint: funlen
// nolint: funlen
func SimulateMsgDelegateFeedConsent(ak types.AccountKeeper, bk types.BankKeeper, k keeper.Keeper) simtypes.Operation {
return func(
r *rand.Rand, app *baseapp.BaseApp, ctx sdk.Context, accs []simtypes.Account, chainID string,
Expand Down