Merged
Conversation
LCyson
approved these changes
Jun 22, 2022
x/dex/exchange/settlement.go
Outdated
| order types.OrderBook, | ||
| takerDirection types.PositionDirection, | ||
| worstPrice sdk.Dec, | ||
| isTakerLiquidation bool, |
Contributor
There was a problem hiding this comment.
can we just pass in the takerOrderType (e.g. types.OrderType_LIQUIDATION) here? so that we don't need to do the check below
Contributor
There was a problem hiding this comment.
also can we add a general comment of the settlement logic in this function
masih
pushed a commit
that referenced
this pull request
Sep 26, 2025
masih
pushed a commit
that referenced
this pull request
Sep 26, 2025
* Allow passing ctx in return values of submsg handler (#52) * Emit owner event before CW721 transfer * Set owner for mint use case * fmt * fix 0x0 addr * revert --------- Co-authored-by: Philip Su <philip.su.522@gmail.com>
masih
pushed a commit
that referenced
this pull request
Sep 26, 2025
* Allow passing ctx in return values of submsg handler (#52) * bump sei-cosmos
masih
pushed a commit
that referenced
this pull request
Oct 1, 2025
masih
pushed a commit
that referenced
this pull request
Oct 9, 2025
[SeiDB] State Store Expose `GetEarliestVersion`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contracts would need order type information for each settlement entry for things like order fee calculation, so sei needs to pass order type during settlement.
Tested with unit tests as well as local integration test with Vortex contract.