Charge rent even if contract failed execution in EndBlock#552
Merged
Charge rent even if contract failed execution in EndBlock#552
Conversation
yzang2019
approved these changes
Feb 8, 2023
Contributor
yzang2019
left a comment
yzang2019
left a comment
There was a problem hiding this comment.
LGTM, let's fix the lint issue
philipsu522
approved these changes
Feb 8, 2023
|
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context Add confidential transfer constants ## Testing performed to validate your change - imported into CT module in a separate branch in e.g. https://github.com/sei-protocol/sei-chain/blob/feature/ct_types/aclmapping/confidentialtransfers/mappings.go#L51
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context Add confidential transfer constants ## Testing performed to validate your change - imported into CT module in a separate branch in e.g. https://github.com/sei-protocol/sei-chain/blob/feature/ct_types/aclmapping/confidentialtransfers/mappings.go#L51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Dex EndBlock has a rollback mechanism such that any state change by a failed contract would be reverted. However this rollback should not include the rent charge applied to the failed contract; the rent should be always be charged. This PR adds an explicit operation for rent charge to be applied to the outer cache store.
Testing performed to validate your change
unit test