Delete contract-related states unpon unregister#554
Merged
Conversation
BrandonWeng
reviewed
Feb 10, 2023
Comment on lines
+48
to
+51
| return append( | ||
| OrderBookContractPrefix(long, contractAddr), | ||
| PairPrefix(priceDenom, assetDenom)..., | ||
| ) |
Contributor
There was a problem hiding this comment.
Do we need to worry about where this is called?
Collaborator
Author
There was a problem hiding this comment.
this is just a refactor so the caller wouldn't see a difference
Contributor
There was a problem hiding this comment.
bbut in the old method it appends the append(prefix wheras this doesnt?
BrandonWeng
approved these changes
Feb 10, 2023
codchen
force-pushed
the
tony-chen-unregister-contract-delete-state
branch
from
c54730e to
0f1335e
Compare
|
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context Remove stale allowlist comment ## Testing performed to validate your change N/A
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context Remove stale allowlist comment ## Testing performed to validate your change N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Remove all states associated with a contract if it is unregistered
Testing performed to validate your change
unit tests