Conversation
|
udpatil
approved these changes
Feb 21, 2023
philipsu522
approved these changes
Feb 21, 2023
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context Add a tracer that can dump all relevant prestate in the db for a traced tx, which can then be used to construct past-scenario test cases. ## Testing performed to validate your change unit test
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context Add a tracer that can dump all relevant prestate in the db for a traced tx, which can then be used to construct past-scenario test cases. ## Testing performed to validate your change unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Problem:
In x/dex/client/cli/tx/tx_register_contract.go, arguments [need hook] and [need order matching], only check against the string true. For example, if a user capitalizes the word, the flag is going to be set as false. Use strconv.ParseBool
Testing performed to validate your change
Tested manually with cli after building sei chain