Conversation
0xeren
reviewed
Jun 26, 2022
Contributor
0xeren
left a comment
0xeren
left a comment
There was a problem hiding this comment.
this mainly for readability not for correctness? looks good
Collaborator
Author
|
@0xeren yes. Can you approve it if it lgty? |
0xeren
approved these changes
Jun 26, 2022
masih
pushed a commit
that referenced
this pull request
Sep 26, 2025
* debug * debug * debug * debug * print out largest size for code * print out addr for large state sizes * flush wasm contracts when reaching state kv len threshold reached * wasm flush every kv pair * go back to flush after threshold * validate-genesis using streaming works * have params on every line in wasm genesis * export, validate, import work locally * cleanup * change name of StreamGenesis to ExportGenesisStream * remove some prints * fix
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context Relevant PR: #313 We are moving the module deposits to the end of the block and transferring them all at once. This is to prevent the gas fee deposit from being a single source of a bottleneck when it comes to concurrency. ## Testing performed to validate your change Ran 3 iterations of load tests with 5 rounds, and 400 orders per block  
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context Relevant PR: #313 We are moving the module deposits to the end of the block and transferring them all at once. This is to prevent the gas fee deposit from being a single source of a bottleneck when it comes to concurrency. ## Testing performed to validate your change Ran 3 iterations of load tests with 5 rounds, and 400 orders per block  
masih
pushed a commit
that referenced
this pull request
Oct 1, 2025
* Have router be restarted if there are no available peers * Fix * rm * Fix backoff * Add restart struct to top level node * test * test * Rm failure injection * add config * rm moniker * add config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we use
gogoprotofor protobuf, the default JSON tag doesn't work and we have to explicitly specifygogoproto.jsontag.All changes in this PR are in
protofiles, and.pb.gochanges are all auto-generated. Since this change doesn't modify marshal/unmarshal behavior (i.e. we didn't add new fields, change data type, or reorder fields), no migration is needed.