This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Merged
Conversation
udpatil
reviewed
Sep 26, 2022
types/context.go
Outdated
| consParams *tmproto.ConsensusParams | ||
| eventManager *EventManager | ||
| priority int64 // The tx priority, only relevant in CheckTx | ||
| txCompletionChannels [][]chan interface{} |
Contributor
There was a problem hiding this comment.
how will we be using these to know when to block / signal on resource need / release
Contributor
Author
There was a problem hiding this comment.
Updated it to be a map of aclops -> []channels
BrandonWeng
force-pushed
the
bweng-ctx
branch
from
8545e0d to
dd77eed
Compare
udpatil
reviewed
Sep 27, 2022
|
|
||
| txBlockingChannels MessageAccessOpsChannelMapping | ||
| txCompletionChannels MessageAccessOpsChannelMapping | ||
| messageIndex int // Used to track current message being processed |
Contributor
There was a problem hiding this comment.
why are we tracking message index instead of txindex? in the other places for dependency mapping, we're indexing by the tx index, this distinction is relevant since each tx can have multiple messages as part of it.
| } | ||
|
|
||
| // Alias for Map of MessageIndex -> AccessOperation -> Channel | ||
| type MessageAccessOpsChannelMapping = map[int]AccessOpsChannelMapping |
Contributor
There was a problem hiding this comment.
this should map by tx index
| func MsgTypeURL(msg Msg) string { | ||
| return "/" + proto.MessageName(msg) | ||
| } | ||
| } No newline at end of file |
philipsu522
approved these changes
Sep 27, 2022
udpatil
approved these changes
Sep 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds transaction channels to context
Had to shuffle around to avoid circular dependency but essentially moved access ops and mapDependency objects to types/, while genesis info remains in x/accessmodule/types
This PR is used in sei-protocol/sei-chain#261