This repository was archived by the owner on Jan 20, 2026. It is now read-only.
[acl] Add dependency switch to support dynamic deps#35
Merged
Conversation
udpatil
force-pushed
the
get-dependencies
branch
from
e3fdeb1 to
c101f1e
Compare
udpatil
force-pushed
the
get-dependencies
branch
from
84e8b56 to
92d7aae
Compare
BrandonWeng
approved these changes
Oct 6, 2022
philipsu522
approved these changes
Oct 6, 2022
Comment on lines
+153
to
+167
| dependencyMapping := k.GetResourceDependencyMapping(ctx, messageKey) | ||
| if dependencyGenerator, ok := k.MessageDependencyGeneratorMapper[types.GenerateMessageKey(msg)]; dependencyMapping.DynamicEnabled && ok { | ||
| // if we have a dependency generator AND dynamic is enabled, use it | ||
| if dependencies, err := dependencyGenerator(k, ctx, msg); err == nil { | ||
| // validate the access ops before using them | ||
| validateErr := types.ValidateAccessOps(dependencies) | ||
| if validateErr == nil { | ||
| return dependencies | ||
| } else { | ||
| ctx.Logger().Error(validateErr.Error()) | ||
| } | ||
| } else { | ||
| ctx.Logger().Error("Error generating message dependencies: ", err) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
would it be possible to add unit tests for this?
This was referenced Oct 7, 2022
BrandonWeng
pushed a commit
that referenced
this pull request
Oct 12, 2022
## Describe your changes and provide context This introduces the `GetMessageDependencies` function that returns the access operations for the message. It either returns the static access ops from the keeper store, or if we've implemented a specific case for that message type, it will generate the dynamic message typing if applicable. ## Testing performed to validate your change Need to refactor sei-chain with this function and verify the default behavior is as expected.
philipsu522
pushed a commit
that referenced
this pull request
Oct 12, 2022
## Describe your changes and provide context This introduces the `GetMessageDependencies` function that returns the access operations for the message. It either returns the static access ops from the keeper store, or if we've implemented a specific case for that message type, it will generate the dynamic message typing if applicable. ## Testing performed to validate your change Need to refactor sei-chain with this function and verify the default behavior is as expected.
BrandonWeng
pushed a commit
that referenced
this pull request
Oct 14, 2022
## Describe your changes and provide context This introduces the `GetMessageDependencies` function that returns the access operations for the message. It either returns the static access ops from the keeper store, or if we've implemented a specific case for that message type, it will generate the dynamic message typing if applicable. ## Testing performed to validate your change Need to refactor sei-chain with this function and verify the default behavior is as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This introduces the
GetMessageDependenciesfunction that returns the access operations for the message. It either returns the static access ops from the keeper store, or if we've implemented a specific case for that message type, it will generate the dynamic message typing if applicable.Testing performed to validate your change
Need to refactor sei-chain with this function and verify the default behavior is as expected.