This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Conversation
codchen
force-pushed
the
pass-sdk-tx-directly
branch
from
0284942 to
bf7286e
Compare
codchen
force-pushed
the
pass-sdk-tx-directly
branch
2 times, most recently
from
1bbf4bb to
b43df68
Compare
codchen
force-pushed
the
pass-sdk-tx-directly
branch
from
b43df68 to
598a024
Compare
codchen
force-pushed
the
pass-sdk-tx-directly
branch
from
1c24fd0 to
5071aeb
Compare
Contributor
|
(@udpatil note this probably will affect OCC's deliverTxBatch interface when we eventually merge these together) |
jewei1997
reviewed
Nov 28, 2023
| // writes do not happen if aborted/failed. This may have some | ||
| // performance benefits, but it'll be more difficult to get right. | ||
| anteCtx, msCache = app.cacheTxContext(ctx, txBytes) | ||
| anteCtx, msCache = app.cacheTxContext(ctx, checksum) |
Contributor
There was a problem hiding this comment.
Can you explain why we use the SHA256 over the txBytes?
Collaborator
Author
There was a problem hiding this comment.
@jewei1997 in cacheTxContext, txBytes is only used to calculate its sha256, so we just pass in the calculated sha256 directly
codchen
added a commit
that referenced
this pull request
Jan 5, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
codchen
added a commit
that referenced
this pull request
Jan 11, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
stevenlanders
pushed a commit
that referenced
this pull request
Jan 30, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Jan 31, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
stevenlanders
pushed a commit
that referenced
this pull request
Feb 6, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
stevenlanders
pushed a commit
that referenced
this pull request
Feb 8, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Mar 1, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Mar 4, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Mar 11, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Mar 14, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Mar 26, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Mar 26, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Mar 27, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Apr 16, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
- To avoid multiple deserialization, as well as adding cached values to sdk.Tx - Add new acl constants for evm subprefixes - Add a new bank send method that doesn't automatically create accounts unit tests & local sei integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change
unit tests & local sei integration