Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Add config to disable seqno#385

Merged
philipsu522 merged 2 commits intomainfrom
disable-seqno-2
Jan 9, 2024
Merged

Add config to disable seqno#385
philipsu522 merged 2 commits intomainfrom
disable-seqno-2

Conversation

@philipsu522
Copy link
Contributor

This reverts commit 1c5a372.

Describe your changes and provide context

Testing performed to validate your change

@philipsu522 philipsu522 changed the title Revert "Revert "Seqno config disable (#354)" (#364)" Add config to disable seqno Dec 27, 2023
@codecov
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c99258c) 54.79% compared to head (21115a2) 54.79%.

❗ Current head 21115a2 differs from pull request most recent head 17592b2. Consider uploading reports for the commit 17592b2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   54.79%   54.79%   -0.01%     
==========================================
  Files         622      622              
  Lines       52166    52196      +30     
==========================================
+ Hits        28585    28600      +15     
- Misses      21498    21511      +13     
- Partials     2083     2085       +2     
Files Coverage Δ
x/auth/ante/sigverify.go 63.58% <100.00%> (+0.22%) ⬆️
x/auth/types/params.go 76.04% <100.00%> (ø)
x/auth/ante/batch_sigverify.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

[(gogoproto.customname) = "SigVerifyCostED25519", (gogoproto.moretags) = "yaml:\"sig_verify_cost_ed25519\""];
uint64 sig_verify_cost_secp256k1 = 5
[(gogoproto.customname) = "SigVerifyCostSecp256k1", (gogoproto.moretags) = "yaml:\"sig_verify_cost_secp256k1\""];
bool disable_seqno_check = 6;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this require migration to the existing params on chain envs?

@philipsu522 philipsu522 enabled auto-merge (squash) January 9, 2024 20:37
@philipsu522 philipsu522 merged commit 66364a5 into main Jan 9, 2024
@philipsu522 philipsu522 deleted the disable-seqno-2 branch January 9, 2024 20:41
yzang2019 pushed a commit that referenced this pull request Feb 5, 2024
This reverts commit 1c5a372.

## Describe your changes and provide context

## Testing performed to validate your change
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants