This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Merged
Conversation
Contributor
|
is there any way to add a unit test for this? i.e. ensure that lock is held before any gas deducted / any toher function calls? not a blocker though - we can revist |
BrandonWeng
added a commit
that referenced
this pull request
Oct 12, 2022
## Describe your changes and provide context There are resource accesses in the ante handler, we need to block before the access occurs, or else we will run into issues there where there's a race condition between the different accesses ## Testing performed to validate your change Ran 20 iterations of the the basic msg load test with 5 validators and didn't experience any issues
philipsu522
pushed a commit
that referenced
this pull request
Oct 12, 2022
There are resource accesses in the ante handler, we need to block before the access occurs, or else we will run into issues there where there's a race condition between the different accesses Ran 20 iterations of the the basic msg load test with 5 validators and didn't experience any issues
BrandonWeng
added a commit
that referenced
this pull request
Oct 14, 2022
## Describe your changes and provide context There are resource accesses in the ante handler, we need to block before the access occurs, or else we will run into issues there where there's a race condition between the different accesses ## Testing performed to validate your change Ran 20 iterations of the the basic msg load test with 5 validators and didn't experience any issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
There are resource accesses in the ante handler, we need to block before the access occurs, or else we will run into issues there where there's a race condition between the different accesses
Testing performed to validate your change
Ran 20 iterations of the the basic msg load test with 5 validators and didn't experience any issues