This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Closed
Conversation
## Describe your changes and provide context Add migration handler to add new disable seqno parameter to chain. Note that i verified that we already use default values so we can just set the params to default instead of maintaining authParamsV1 and V2 ## Testing performed to validate your change - unit tests - upgraded local chain, ensure that bank sends work
## Changelog * Ensure we have panic recovery handlers in `PrepareProposal` and `ProcessProposal`.
…tion (#404) ## Describe your changes and provide context This removes the behavior of disabling a dynamic dependency generator if it returns something invalid during message dependency generation. This needs to be removed so that the state writes are consistent with synchronous execution, such that message dependency generation is a read-only path. This change won't cause correctness issues, but in the case that there is an incorrect dynamic dependency generator, it will result in wasted compute since it will try it every time instead of disabling it after the first time it was incorrect. This seems like an acceptable compromise in order to have consistency with synchronous execution. ## Testing performed to validate your change Updated unit tests, and tested this behavior on a loadtest cluster
## Describe your changes and provide context This should fix the concurrent map access for storeV2 root multistore over (rs.ckvStores). The problem is that it is currently not protected by a read lock so when other goroutine modify the map, it will throw panic ## Testing performed to validate your change
## Describe your changes and provide context Fix a bunch of minor issues from audit: - LoadVersionAndUpgrade should not ignore version - Simplify CacheWrap to avoid wrapping twice - SS store query is not setting height correctly in the query response - Add panic logic for bumpversion if it is false in commit - Use the correct commit info in query ## Testing performed to validate your change
stevenlanders
changed the title
This reverts commit e12efbc.
philipsu522
approved these changes
Feb 6, 2024
Contributor
Author
|
closing this and keeping #422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change