This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Conversation
codchen
force-pushed
the
evm-remove-wei-escrow
branch
from
81af641 to
3e713c9
Compare
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
udpatil
pushed a commit
that referenced
this pull request
Mar 1, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
udpatil
pushed a commit
that referenced
this pull request
Mar 4, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
udpatil
pushed a commit
that referenced
this pull request
Mar 11, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
udpatil
pushed a commit
that referenced
this pull request
Mar 14, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
udpatil
pushed a commit
that referenced
this pull request
Mar 26, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
udpatil
pushed a commit
that referenced
this pull request
Mar 26, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
udpatil
pushed a commit
that referenced
this pull request
Mar 27, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
udpatil
pushed a commit
that referenced
this pull request
Apr 16, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
## Describe your changes and provide context Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks ## Testing performed to validate your change unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Since add and sub balance are now decoupled, we no longer need an explicit escrow account, and can implicitly represent "escrow" by direct crediting/debiting account's usei balances. This PR removes the explicit escrow account logic, and also added wei logic in invariant checks
Testing performed to validate your change
unit tests