Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Amplify cosmos tx priority#443

Merged
codchen merged 1 commit intoevmfrom
amplify-priority
Feb 27, 2024
Merged

Amplify cosmos tx priority#443
codchen merged 1 commit intoevmfrom
amplify-priority

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Feb 27, 2024

Describe your changes and provide context

Since EVM transactions specify gas price in unit of wei, we have started representing priority of EVM transactions in wei-per-gas. In order for cosmos transactions' priority to be comparable with EVM transactions', we would like to use the same unit for priority here as well. Hence in this PR we amplify cosmos transaction priority by 10^12 (if the original priority is based on the base denom aka usei)

Testing performed to validate your change

unit test

@codchen codchen requested a review from jewei1997 February 27, 2024 06:58
Copy link
Contributor

@jewei1997 jewei1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jewei1997
Copy link
Contributor

Just FYI seeing this on a cosmos bank send with this cmd:

seid tx bank send $(seid keys show admin -a) sei1m9qugvk4h66p6hunfajfg96ysc48zeq4m0d82c 1usei --fees 20000usei -b block -y

this is my output:

c.Amount is 20000 BaseDenomGasPriceAmplfier is 1000000000000 gas is 200000
gasPrice is 100000000000 <- 10^11
priority is 100000000000 <- 10^11

@codchen codchen merged commit 8913148 into evm Feb 27, 2024
@codchen codchen deleted the amplify-priority branch February 27, 2024 15:57
udpatil pushed a commit that referenced this pull request Feb 28, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
udpatil pushed a commit that referenced this pull request Feb 28, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
udpatil pushed a commit that referenced this pull request Mar 1, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
udpatil pushed a commit that referenced this pull request Mar 4, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
udpatil pushed a commit that referenced this pull request Mar 11, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
udpatil pushed a commit that referenced this pull request Mar 14, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
udpatil pushed a commit that referenced this pull request Mar 26, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
udpatil pushed a commit that referenced this pull request Mar 26, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
udpatil pushed a commit that referenced this pull request Mar 27, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
udpatil pushed a commit that referenced this pull request Apr 16, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
udpatil pushed a commit that referenced this pull request Apr 19, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
udpatil pushed a commit that referenced this pull request Apr 19, 2024
## Describe your changes and provide context
Since EVM transactions specify gas price in unit of wei, we have started
representing priority of EVM transactions in wei-per-gas. In order for
cosmos transactions' priority to be comparable with EVM transactions',
we would like to use the same unit for priority here as well. Hence in
this PR we amplify cosmos transaction priority by 10^12 (if the original
priority is based on the base denom aka usei)

## Testing performed to validate your change
unit test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants