This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Add AnteHandler access ops and move completion channel signalling#56
Merged
BrandonWeng merged 3 commits intomainfrom Oct 17, 2022
Merged
Add AnteHandler access ops and move completion channel signalling#56BrandonWeng merged 3 commits intomainfrom
BrandonWeng merged 3 commits intomainfrom
Conversation
codchen
approved these changes
Oct 17, 2022
BrandonWeng
added a commit
that referenced
this pull request
Oct 17, 2022
## Describe your changes and provide context * Adds the AnteHandlers Dependency Decorators for the decorators that have read/write operations to/from keepers * Moves the MsgCompletion signaling to the end of RunTx. The main issue is that the signaling SHOULD happen after the write() calls so that dependent transactions have the updated data. * We can make it more granular in the future but for now we should just move it out so that its easier to reason/ ## Testing performed to validate your change With this branch - able to run a couple of rounds of load testing before running into the app hash error due to different gas consumed for the same TX on validators, this is with concurrency enabled sei-protocol/sei-chain#309
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change
With this branch - able to run a couple of rounds of load testing before running into the app hash error due to different gas consumed for the same TX on validators, this is with concurrency enabled
sei-protocol/sei-chain#309