This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Merged
Conversation
BrandonWeng
force-pushed
the
bweng-fixunit-tests
branch
from
179982e to
50a2c96
Compare
udpatil
reviewed
Oct 28, 2022
|
|
||
| // Try subtract from the in mem var first, prevents the condition where | ||
| // the module may have a pending deposit that would be enough to pay for this send | ||
| ok := ctx.ContextMemCache().SafeSubDeferredSends(moduleName, amounts) |
Contributor
There was a problem hiding this comment.
is it safe to add this in the normal BurnCoins and not the DeferredBurn? Doesn't that make the deferred mem resources a potential race condition?
Contributor
Author
There was a problem hiding this comment.
This is in the case where we call deferredMint and then call the regular burn, in this case if we don't check the deferred sends then it will error out with insufficient balance.
The deferred in mem variables are all blocked by mutex, I think in this case we only care about the absolute value of the in-mem variables at the end of FinalizeBlocker, as only a single value is written to the store
udpatil
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
With the deferred logic, we need to also check the pending deposits when subtracting coins from the module accounts, this was added to some of the methods, but some other areas were missed
Testing performed to validate your change