This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Add all TokenFactory, Staking and Oracle Proto#79
Merged
BrandonWeng merged 9 commits intomainfrom Oct 29, 2022
Merged
Conversation
BrandonWeng
changed the title
udpatil
approved these changes
Oct 28, 2022
| KV_TOKENFACTORY_METADATA = 22; // child of KV_TOKENFACTORY | ||
| KV_TOKENFACTORY_ADMIN = 23; // child of KV_TOKENFACTORY | ||
| KV_TOKENFACTORY_CREATOR = 24; // child of KV_TOKENFACTORY | ||
| KV_ORACLE_EXCHANGE_RATE = 25; // child of KV_ORACLE |
Contributor
There was a problem hiding this comment.
do we need to do anything to the existing oracle ones (do they conflict in any way)? It looks fine, but not sure if any changes we made affect them
Contributor
Author
There was a problem hiding this comment.
They should be fine, I tried to make sure that each prefix key has their own child, so at least it should be 1-1
| KV_STAKING_REDELEGATION_QUEUE = 36; // child of KV_STAKING | ||
| KV_STAKING_VALIDATOR_QUEUE = 37; // child of KV_STAKING | ||
| KV_STAKING_HISTORICAL_INFO = 38; // child of KV_STAKING | ||
| KV_STAKING_UNBOUNDING = 39; // child of KV_STAKING |
Contributor
There was a problem hiding this comment.
nit: typo - should be UNBONDING
| KV_STAKING_VALIDATION_POWER = 28; // child of KV_STAKING | ||
| KV_STAKING_TOTAL_POWER = 29; // child of KV_STAKING | ||
| KV_STAKING_VALIDATORS_CON_ADDR = 30; // child of KV_STAKING | ||
| KV_STAKING_UNBOUNDING_DELEGATION = 31; // child of KV_STAKING |
Contributor
There was a problem hiding this comment.
nit: type - should be UNBONDING (same for next line)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Adding child leaves for all the token factory, oracle and staking.
Found it tedious going back and forth updating the keys for each
sei-protocol/sei-chain#350
Testing performed to validate your change
Proto Files