This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Merged
Conversation
codchen
reviewed
Nov 1, 2022
types/handler.go
Outdated
| return txDeps, nil | ||
| // TODO:: use the commit access helper - blocked by circular dep. Should move it to the type/accesscontrol instead | ||
| commit := sdkacltypes.AccessOperation{ | ||
| ResourceType: sdkacltypes.ResourceType_ANY, |
Collaborator
There was a problem hiding this comment.
can you help me understand why we need this if ante handler will eventually be followed by the actual msg's dependency list which already ends with a COMMIT?
Contributor
Author
There was a problem hiding this comment.
actually, yeah that's a good point. Let me remove this and validate the access ops another way - the validate access ops call always assert that there's a COMMIT at the end, this breaks down when we're just validating the ante handlers
codchen
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Updates ante handler dependencies
Testing performed to validate your change
sei-protocol/sei-chain#354