Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Broadcast result should also pass log#201

Merged
yzang2019 merged 4 commits intomainfrom
yzang/SEI-6571
Feb 7, 2024
Merged

Broadcast result should also pass log#201
yzang2019 merged 4 commits intomainfrom
yzang/SEI-6571

Conversation

@yzang2019
Copy link
Contributor

Describe your changes and provide context

Problem:
Current Tendermint is not passing log into the broadcast result, this would cause some information missing when trying to debug broadcast failures.

Testing performed to validate your change

@codecov
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (da59b8d) 57.94% compared to head (017aba2) 57.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   57.94%   57.92%   -0.02%     
==========================================
  Files         249      249              
  Lines       33915    33916       +1     
==========================================
- Hits        19651    19645       -6     
- Misses      12692    12705      +13     
+ Partials     1572     1566       -6     
Files Coverage Δ
internal/rpc/core/mempool.go 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants