This repository was archived by the owner on Jan 20, 2026. It is now read-only.
hardcoded simple-priority queue as the only message queue#308
Merged
Conversation
sei-will
approved these changes
Sep 2, 2025
yzang2019
reviewed
Sep 2, 2025
yzang2019
approved these changes
Sep 3, 2025
stevenlanders
approved these changes
Sep 3, 2025
philipsu522
added a commit
that referenced
this pull request
Oct 7, 2025
…)" This reverts commit 72558f1.
This was referenced Oct 16, 2025
pompon0
added a commit
that referenced
this pull request
Oct 16, 2025
#308 has accidentally changed the semantics of ParseAddressString from resolving the tcp address to parsing tcp address. As a side effect, support for DNS names in the config has been removed. This PR reverts to the original semantics to support DNS names again. Also renamed the functions to better describe what they do.
pdrobnjak
pushed a commit
to sei-protocol/sei-chain
that referenced
this pull request
Oct 17, 2025
sei-protocol/sei-tendermint#308 has accidentally changed the semantics of ParseAddressString from resolving the tcp address to parsing tcp address. As a side effect, support for DNS names in the config has been removed. This PR reverts to the original semantics to support DNS names again. Also renamed the functions to better describe what they do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were multiple queue type options that you could select in the seid config.
It is known that the only simple-priority queue works reasonably and it should have been an implementation detail of the seid node anyway, so I've removed the other options removing the abstraction.
The additional benefit is that the unit tests are using the real thing instead of FIFO
Additionally: