Change xargs command for mac and increase fees#14
Open
shawnljh wants to merge 2 commits intosei-protocol:mainfrom
Open
Change xargs command for mac and increase fees#14shawnljh wants to merge 2 commits intosei-protocol:mainfrom
shawnljh wants to merge 2 commits intosei-protocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a compatibility issue I found when trying to run the deploy script. The
xargscommand seems to fail on macOS.Issue Background
While following the tutorial, I add trouble executing the deploy script on my Macbook. After investigating, I found that the issue originates from: 1) the
xargscommand and 2) the low fees in thewasm instantiate commandProposed solution
I have modified the deployment script to detect the OS and if it's mac, use the
sedcommand instead to trim whitespaces. I also increased the fees amount to fix the following error:raw_log: '[{"log":"insufficient fees; got: 300000usei required: 3000000usei: insufficient fee"}]